Enable compaction ITs on MSQ engine #16778
Merged
kfaraz merged 7 commits intoapache:masterfrom Jul 30, 2024
Merged
Conversation
github-actions
Bot
added
Area - Batch Ingestion
Area - Ingestion
Area - MSQ
# Conflicts: # extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/MSQCompactionRunner.java
kfaraz
reviewed
Jul 23, 2024
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
The actual IT changes look good.
Have some queries around the other fixes.
kfaraz
reviewed
Jul 25, 2024
kfaraz
approved these changes
Jul 29, 2024
Contributor
kfaraz
left a comment
kfaraz
left a comment
There was a problem hiding this comment.
+1 after merge conflicts are resolved and CI is green.
Thanks for the tests, @gargvishesh !
# Conflicts: # extensions-core/multi-stage-query/src/test/java/org/apache/druid/msq/indexing/MSQCompactionRunnerTest.java # server/src/main/java/org/apache/druid/client/indexing/ClientCompactionRunnerInfo.java # server/src/test/java/org/apache/druid/client/indexing/ClientCompactionRunnerInfoTest.java
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
Follow-up to apache#16291, this commit enables a subset of existing native compaction ITs on the MSQ engine. In the process, the following changes have been introduced in the MSQ compaction flow: - Populate `metricsSpec` in `CompactionState` from `querySpec` in `MSQControllerTask` instead of `dataSchema` - Add check for pre-rolled-up segments having `AggregatorFactory` with different input and output column names - Fix passing missing cluster-by clause in scan queries - Add annotation of `CompactionState` to tombstone segments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #16291, this PR enables a subset of existing native compaction ITs on the MSQ engine. In the process, the following changes are introduced in the MSQ compaction flow:
metricsSpecinCompactionStatefromquerySpecinMSQControllerTaskinstead ofdataSchemaAggregatorFactorywith different input and output column namesCompactionStateto tombstone segmentsThis PR has: