-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Priority based task locking #1679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
...ng-service/src/main/java/io/druid/indexing/common/actions/SetLockCriticalStateAction.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,116 @@ | ||
| /* | ||
| * Licensed to Metamarkets Group Inc. (Metamarkets) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. Metamarkets licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
|
|
||
| package io.druid.indexing.common.actions; | ||
|
|
||
|
|
||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
| import com.fasterxml.jackson.annotation.JsonIgnore; | ||
| import com.fasterxml.jackson.annotation.JsonProperty; | ||
| import com.fasterxml.jackson.core.type.TypeReference; | ||
| import io.druid.indexing.common.task.Task; | ||
| import org.joda.time.Interval; | ||
|
|
||
| import java.io.IOException; | ||
|
|
||
| public class SetLockCriticalStateAction implements TaskAction<Boolean> { | ||
|
|
||
| @JsonIgnore | ||
| private final Interval interval; | ||
| @JsonIgnore | ||
| private final TaskLockCriticalState taskLockCriticalState; | ||
|
|
||
| @JsonCreator | ||
| public SetLockCriticalStateAction( | ||
| @JsonProperty("interval") Interval interval, | ||
| @JsonProperty("taskLockCriticalState") TaskLockCriticalState taskLockCriticalState | ||
| ) | ||
| { | ||
| this.taskLockCriticalState = taskLockCriticalState; | ||
| this.interval = interval; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public Interval getInterval() | ||
| { | ||
| return interval; | ||
| } | ||
|
|
||
| @JsonProperty | ||
| public TaskLockCriticalState getTaskLockCriticalState() | ||
| { | ||
| return taskLockCriticalState; | ||
| } | ||
|
|
||
| @Override | ||
| public TypeReference<Boolean> getReturnTypeReference() | ||
| { | ||
| return new TypeReference<Boolean>() | ||
| { | ||
| }; | ||
| } | ||
|
|
||
| @Override | ||
| public Boolean perform( | ||
| Task task, TaskActionToolbox toolbox | ||
| ) throws IOException | ||
| { | ||
| return toolbox.getTaskLockbox().setTaskLockCriticalState(task, interval, taskLockCriticalState); | ||
| } | ||
|
|
||
| @Override | ||
| public boolean isAudited() | ||
| { | ||
| return false; | ||
| } | ||
|
|
||
| @Override | ||
| public String toString(){ | ||
| return "SetLockCriticalStateAction{ " + | ||
| "Interval = " + interval + ", TaskLockCriticalState = " + taskLockCriticalState + | ||
| " }"; | ||
| } | ||
|
|
||
| @Override | ||
| public boolean equals(Object o) | ||
| { | ||
| if (this == o) { | ||
| return true; | ||
| } | ||
| if (o == null || getClass() != o.getClass()) { | ||
| return false; | ||
| } | ||
|
|
||
| SetLockCriticalStateAction that = (SetLockCriticalStateAction) o; | ||
|
|
||
| if (!getInterval().equals(that.getInterval())) { | ||
| return false; | ||
| } | ||
| return getTaskLockCriticalState() == that.getTaskLockCriticalState(); | ||
|
|
||
| } | ||
|
|
||
| @Override | ||
| public int hashCode() | ||
| { | ||
| int result = getInterval().hashCode(); | ||
| result = 31 * result + getTaskLockCriticalState().hashCode(); | ||
| return result; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gianm Is this a reasonable assumption that there will be a corresponding
TaskLockwith same interval for each segment being published byKafkaIndexTask?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gianm can you please look at this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pjain1 Do you mean the exact same interval or just one that contains it? It will have a lock that contains the segment interval, but it might not be the exact same interval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be somewhat larger I mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant exact same interval, I search for a
TaskLockPossefor this task having the same interval. Doesn't kafkaIndexTask will acquire lock as it announces the segments ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does acquire locks as it announces, although it's possible that it will announce a segment under a "wider" lock (like announce an hourly segment under a daily lock)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it uses
SegmentAllocateActionI can change the check tocontainsinstead ofequalsand that should take care of this case hopefullyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done