Skip to content

Fix issues with fetching task reports in SQL statements endpoint for MiddleManager setups#16832

Merged
zachjsh merged 1 commit intoapache:masterfrom
Akshat-Jain:sql-statements-api-fix-middlemanager-issues
Aug 2, 2024
Merged

Fix issues with fetching task reports in SQL statements endpoint for MiddleManager setups#16832
zachjsh merged 1 commit intoapache:masterfrom
Akshat-Jain:sql-statements-api-fix-middlemanager-issues

Conversation

@Akshat-Jain
Copy link
Copy Markdown
Contributor

Description

This PR fixes the issues with fetching task reports in SQL statements endpoint for middlemanager setups.

With #16808, we started fetching task report using indexer API, but in the case of MiddleManager setups - the overlord API initially ends up throwing "Unable to contact overlord" until the peons are ready.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions Bot added Area - Batch Ingestion Area - Querying Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Aug 2, 2024
Copy link
Copy Markdown
Contributor

@dkoepke dkoepke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick turnaround.

mcbrewster
mcbrewster approved these changes Aug 2, 2024
@zachjsh zachjsh merged commit 63ba5a4 into apache:master Aug 2, 2024
sreemanamala pushed a commit to sreemanamala/druid that referenced this pull request Aug 6, 2024
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Querying Development Blocker

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants