Add metrics for number of rows/bytes materialized while running subqueries#16835
Merged
LakshSingla merged 3 commits intoapache:masterfrom Aug 5, 2024
Merged
Add metrics for number of rows/bytes materialized while running subqueries#16835LakshSingla merged 3 commits intoapache:masterfrom
LakshSingla merged 3 commits intoapache:masterfrom
Conversation
cryptoe
reviewed
Aug 2, 2024
| SubqueryCountStatsProvider subqueryStatsProvider | ||
| final boolean useNestedForUnknownTypeInSubquery, | ||
| final SubqueryCountStatsProvider subqueryStatsProvider, | ||
| final boolean emitMetrics, |
Contributor
There was a problem hiding this comment.
Could you please java doc why this dryRun flag is needed
cryptoe
approved these changes
Aug 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the metrics to analyze the size of the results materialized by the subquery's results on the heap. The following metrics are added:
subquery/rows- Number of rows produced by the subquerysubquery/bytes- Bytes produced by the subqueryBoth the metrics have
idandsubQueryIdin the dimensions.Release note
subquery/rowsandsubquery/bytesmetrics have been added, which indicate the size of the results materialized on the heap.Key changed/added classes in this PR
This PR has: