Skip to content

Memoize the redundant calls to overlord in sql statements endpoint#16839

Merged
LakshSingla merged 2 commits intoapache:masterfrom
Akshat-Jain:sql-statement-overlord-calls
Aug 5, 2024
Merged

Memoize the redundant calls to overlord in sql statements endpoint#16839
LakshSingla merged 2 commits intoapache:masterfrom
Akshat-Jain:sql-statement-overlord-calls

Conversation

@Akshat-Jain
Copy link
Copy Markdown
Contributor

Description

With the changes in #16808, we are contacting overlord multiple times for fetching task reports which is redundant, and may cause performance issues.

This PR changes the implementation to memoize the fetched response and remove redundant calls to overlord.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions Bot added Area - Batch Ingestion Area - Querying Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Aug 5, 2024
@LakshSingla LakshSingla merged commit 08f9ec1 into apache:master Aug 5, 2024
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Querying

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants