Skip to content

docs: update query from deepstorage segment requirement#16842

Merged
317brian merged 7 commits intoapache:masterfrom
317brian:docs-q-from-ds-update
Aug 23, 2024
Merged

docs: update query from deepstorage segment requirement#16842
317brian merged 7 commits intoapache:masterfrom
317brian:docs-q-from-ds-update

Conversation

@317brian
Copy link
Copy Markdown
Contributor

@317brian 317brian commented Aug 5, 2024

#16676 enables querying from completely cold datasources. Updated the docs to reflect that.

This PR has:

  • been self-reviewed

@317brian
Copy link
Copy Markdown
Contributor Author

317brian commented Aug 5, 2024

@findingrish PTAL

Comment thread docs/configuration/index.md Outdated
Comment thread docs/querying/query-from-deep-storage.md Outdated
Comment thread docs/tutorials/tutorial-query-deep-storage.md Outdated
Copy link
Copy Markdown
Contributor

@ektravel ektravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions.

@findingrish
Copy link
Copy Markdown
Contributor

Hi, @317brian, can we please update the docs to mention that the datasource schema would be built from the segment schema present in the metadata database. If the feature is turned on for the first time, users will have to manually load the cold segments, wait for their schema to be backfilled in the metadata database and finally unload them.

Co-authored-by: Katya Macedo  <38017980+ektravel@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@ektravel ektravel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@317brian
Copy link
Copy Markdown
Contributor Author

@findingrish ptal when you get a chance. I've updated it with the info about backfilling the metadata db

Comment thread docs/configuration/index.md Outdated
Comment thread docs/querying/query-from-deep-storage.md Outdated
Comment thread docs/querying/query-from-deep-storage.md Outdated
Comment thread docs/querying/query-from-deep-storage.md Outdated
Comment thread docs/querying/query-from-deep-storage.md Outdated
Comment thread docs/tutorials/tutorial-query-deep-storage.md Outdated
Co-authored-by: Rishabh Singh <6513075+findingrish@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@findingrish findingrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@317brian 317brian merged commit 418da92 into apache:master Aug 23, 2024
@317brian 317brian deleted the docs-q-from-ds-update branch August 23, 2024 18:59
hevansDev pushed a commit to hevansDev/druid that referenced this pull request Aug 29, 2024
Co-authored-by: Katya Macedo  <38017980+ektravel@users.noreply.github.com>
Co-authored-by: Rishabh Singh <6513075+findingrish@users.noreply.github.com>
Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com>
edgar2020 pushed a commit to edgar2020/druid that referenced this pull request Sep 5, 2024
Co-authored-by: Katya Macedo  <38017980+ektravel@users.noreply.github.com>
Co-authored-by: Rishabh Singh <6513075+findingrish@users.noreply.github.com>
Co-authored-by: Katya Macedo <38017980+ektravel@users.noreply.github.com>
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants