Skip to content

Propagate TooManyRowsInAWindowFault error message properly to the user#16906

Merged
kfaraz merged 2 commits intoapache:masterfrom
Akshat-Jain:add-TooManyRowsInAWindowFault-to-MSQIndexingModule
Aug 18, 2024
Merged

Propagate TooManyRowsInAWindowFault error message properly to the user#16906
kfaraz merged 2 commits intoapache:masterfrom
Akshat-Jain:add-TooManyRowsInAWindowFault-to-MSQIndexingModule

Conversation

@Akshat-Jain
Copy link
Copy Markdown
Contributor

Description

Currently, TooManyRowsInAWindowFault isn't propagated properly to the user. The user sees the following:
image

Instead, the user should see the proper error message defined in TooManyRowsInAWindowFault.java. The issue was that TooManyRowsInAWindowFault wasn't added to the list of fault classes in MSQIndexingModule.

With this PR's changes, TooManyRowsInAWindowFault's error message is propagated properly to the end user:
Screenshot 2024-08-16 at 12 43 10 PM


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions Bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Aug 16, 2024
Copy link
Copy Markdown
Contributor

@LakshSingla LakshSingla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this in the MSQFaultsSerdeTest as well

@Akshat-Jain
Copy link
Copy Markdown
Contributor Author

Please add this in the MSQFaultsSerdeTest as well

@LakshSingla Done

@kfaraz kfaraz merged commit a56b5c0 into apache:master Aug 18, 2024
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants