Propagate TooManyRowsInAWindowFault error message properly to the user#16906
Merged
kfaraz merged 2 commits intoapache:masterfrom Aug 18, 2024
Merged
Conversation
adarshsanjeev
approved these changes
Aug 16, 2024
LakshSingla
reviewed
Aug 16, 2024
Contributor
LakshSingla
left a comment
There was a problem hiding this comment.
Please add this in the MSQFaultsSerdeTest as well
Contributor
Author
@LakshSingla Done |
LakshSingla
approved these changes
Aug 16, 2024
kfaraz
approved these changes
Aug 18, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently,

TooManyRowsInAWindowFaultisn't propagated properly to the user. The user sees the following:Instead, the user should see the proper error message defined in
TooManyRowsInAWindowFault.java. The issue was thatTooManyRowsInAWindowFaultwasn't added to the list of fault classes in MSQIndexingModule.With this PR's changes,

TooManyRowsInAWindowFault's error message is propagated properly to the end user:This PR has: