Add supervisor log when task count is greater than partitions#16948
Merged
georgew5656 merged 7 commits intoapache:masterfrom Aug 26, 2024
Merged
Add supervisor log when task count is greater than partitions#16948georgew5656 merged 7 commits intoapache:masterfrom
georgew5656 merged 7 commits intoapache:masterfrom
Conversation
kfaraz
reviewed
Aug 23, 2024
…blestream/supervisor/SeekableStreamSupervisor.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
…blestream/supervisor/SeekableStreamSupervisor.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
…blestream/supervisor/SeekableStreamSupervisor.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
kfaraz
approved these changes
Aug 23, 2024
hevansDev
pushed a commit
to hevansDev/druid
that referenced
this pull request
Aug 29, 2024
…#16948) * Add log message when task count is higher than partitions * newline * fix ordering * Add supervisor id * Update indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com> * Update indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com> * Update indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com> --------- Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
edgar2020
pushed a commit
to edgar2020/druid
that referenced
this pull request
Sep 5, 2024
…#16948) * Add log message when task count is higher than partitions * newline * fix ordering * Add supervisor id * Update indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com> * Update indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com> * Update indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com> --------- Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently streaming supervisors will handle the case where the # of task groups is greater than the # of partitions available by truncating the # of task groups to the # of partitions (see KafkaSupervisor.getTaskGroupIdForPartition). This is okay behavior but its nice to know when this situation occurs (because it indicates the kafka topic should be scaled up).
Description
Add a warn log when discovering partitions from streams if the # of discovered partitions is less than the number of task groups configured. This seemed like the best place to do this.
The other place i considered was in generateReport, but thats only called when the supervisor /status endpoint is called or if debug logging is enabled.
Release note
Key changed/added classes in this PR
SeekableStreamSupervisorThis PR has: