Skip to content

Convert MSQTerminalStageSpecFactory into an interface#16996

Merged
cryptoe merged 2 commits intoapache:masterfrom
adarshsanjeev:msq-stage-spec-change
Sep 6, 2024
Merged

Convert MSQTerminalStageSpecFactory into an interface#16996
cryptoe merged 2 commits intoapache:masterfrom
adarshsanjeev:msq-stage-spec-change

Conversation

@adarshsanjeev
Copy link
Copy Markdown
Contributor

@adarshsanjeev adarshsanjeev commented Sep 4, 2024

This PR performs a minor refactor which converts MSQTerminalStageSpecFactory into an interface.
MSQTerminalStageSpecFactory was introduced in #16699.

Changing this class into an interface will allow configuring the behavior directly by binding the required implementation.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions Bot added Area - Batch Ingestion Area - Querying Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Sep 4, 2024
github-advanced-security[bot]
github-advanced-security AI found potential problems Sep 4, 2024
View reviewed changes
Comment thread .../multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQTerminalStageSpecFactory.java
{
return SegmentGenerationStageSpec.instance();
}
TerminalStageSpec createTerminalStageSpec(DruidQuery druidQuery, PlannerContext plannerContext);

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'druidQuery' is never used.
Comment thread .../multi-stage-query/src/main/java/org/apache/druid/msq/guice/MSQTerminalStageSpecFactory.java
{
return SegmentGenerationStageSpec.instance();
}
TerminalStageSpec createTerminalStageSpec(DruidQuery druidQuery, PlannerContext plannerContext);

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'plannerContext' is never used.
cryptoe
cryptoe approved these changes Sep 6, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@cryptoe cryptoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cryptoe cryptoe merged commit 73ff9f9 into apache:master Sep 6, 2024
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cryptoe cryptoe cryptoe approved these changes

Assignees

No one assigned

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Querying

Projects

None yet

Milestone

31.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@adarshsanjeev @cryptoe @github-advanced-security @kfaraz