Skip to content

Window Functions : Reject MVDs during window processing#17002

Merged
abhishekagarwal87 merged 5 commits intoapache:masterfrom
sreemanamala:window-mvds
Sep 9, 2024
Merged

Window Functions : Reject MVDs during window processing#17002
abhishekagarwal87 merged 5 commits intoapache:masterfrom
sreemanamala:window-mvds

Conversation

@sreemanamala
Copy link
Copy Markdown
Contributor

Description

This commit aims to reject MVDs in window processing as we do not support them.
Earlier to this commit, query running a window aggregate partitioned by an MVD column would fail with ClassCastException


Key changed/added classes in this PR
  • ArrayListRowsAndColumns

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Comment thread sql/src/test/java/org/apache/druid/sql/calcite/CalciteWindowQueryTest.java Outdated
@sreemanamala sreemanamala deleted the window-mvds branch September 18, 2024 11:24
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants