Skip tombstone segment refresh in metadata cache#17025
Merged
cryptoe merged 11 commits intoapache:masterfrom Sep 13, 2024
Merged
Skip tombstone segment refresh in metadata cache#17025cryptoe merged 11 commits intoapache:masterfrom
cryptoe merged 11 commits intoapache:masterfrom
Conversation
cryptoe
reviewed
Sep 10, 2024
| return null; | ||
| } | ||
| return segmentMetadataInfo.get(datasource).get(segmentId); | ||
| return segmentMetadataInfo.getOrDefault(datasource, new ConcurrentSkipListMap<>()).get(segmentId); |
Contributor
There was a problem hiding this comment.
Why would you create a new object if its not used. Less GC that way.
Isn't the older code more performant ?
Contributor
Author
There was a problem hiding this comment.
Reverted this change.
Contributor
Author
There was a problem hiding this comment.
My original branch was outdated, there was a race in the original implementation which was fixed in #16981.
| // Additionally, segment metadata queries, which are not yet implemented for tombstone segments | ||
| // (see: https://github.com/apache/druid/pull/12137) do not provide metadata for tombstones, | ||
| // leading to indefinite refresh attempts for these segments. | ||
| Set<SegmentId> segmentsWithoutTombstone = |
Contributor
There was a problem hiding this comment.
Why do we need to materialize this.
Why can't we return a iterable which just skips the tombstone segments ?
We can always increment counters there no ?
Contributor
Author
There was a problem hiding this comment.
I have refactored to ensure that the stream is not materialized.
For count I have added a terminal operation but that wouldn't materialize the entire stream.
Contributor
Author
There was a problem hiding this comment.
I just changed the approach yesterday. Instead of filtering out the tombstone segments in the end before refresh, I am ensuring they are never marked for refresh.
A segment is marked for refresh in following scenarios:
- Segment is added.
- Datasource signature is built and schema for segment is missing.
- Metadata for the segment is fetched and schema for the segment is missing.
I have ensured that a tombstone segment never gets marked for refresh itself.
added 5 commits
September 11, 2024 11:26
cryptoe
approved these changes
Sep 12, 2024
| markSegmentAsNeedRefresh(segmentId); | ||
| log.debug("SchemaMetadata for segmentId [%s] is absent.", segmentId); | ||
|
|
||
| if (entry.getValue().getSegment().isTombstone()) { |
Contributor
There was a problem hiding this comment.
This block of code is repeated multiple times.
can be added in a method markForRefreshifnottombstone?
Contributor
Author
There was a problem hiding this comment.
Refactored it and also added the check for unused segment.
We do not want to mark an unused segment for refresh encountered while fetching metadata.
findingrish
added a commit
to findingrish/druid
that referenced
this pull request
Sep 16, 2024
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache. It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache. The fix is to keep the segment in the metadata cache but skip them from refresh. This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
findingrish
added a commit
to findingrish/druid
that referenced
this pull request
Sep 16, 2024
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache. It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache. The fix is to keep the segment in the metadata cache but skip them from refresh. This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
pranavbhole
pushed a commit
to pranavbhole/druid
that referenced
this pull request
Sep 17, 2024
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache. It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache. The fix is to keep the segment in the metadata cache but skip them from refresh. This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
findingrish
added a commit
to findingrish/druid
that referenced
this pull request
Sep 19, 2024
This PR apache#16890 introduced a change to skip adding tombstone segments to the cache. It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache. The fix is to keep the segment in the metadata cache but skip them from refresh. This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
abhishekagarwal87
pushed a commit
that referenced
this pull request
Sep 19, 2024
This PR #16890 introduced a change to skip adding tombstone segments to the cache. It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache. The fix is to keep the segment in the metadata cache but skip them from refresh. This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent issue: #14989
This PR #16890 introduced a change to skip adding tombstone segments to the cache.
It turns out that as a side effect tombstone segments appear unavailable in the console. This happens because availability of a segment in Broker is determined from the metadata cache.
The fix is to keep the segment in the metadata cache but skip them from refresh.
This doesn't affect any functionality as metadata query for tombstone returns empty causing continuous refresh of those segments.