Skip to content

Support maxColumnsToMerge in supervisor tuningConfig#17030

Merged
georgew5656 merged 5 commits intoapache:masterfrom
georgew5656:maxColumnToMerge
Sep 11, 2024
Merged

Support maxColumnsToMerge in supervisor tuningConfig#17030
georgew5656 merged 5 commits intoapache:masterfrom
georgew5656:maxColumnToMerge

Conversation

@georgew5656
Copy link
Copy Markdown
Contributor

@georgew5656 georgew5656 commented Sep 10, 2024

The StreamAppenderator already supports using maxColumnsToMerge from tuningConfig, the only thing preventing this property from being used is the supervisor/streaming task specs not supporting it.

It would be nice if we could automatically set the value like in MSQE but for now, just let the user specify the value (defaults to -1 which is current behavior).

Release note

  • add new supervisor tuningConfig property (maxColumnsToMerge)
Key changed/added classes in this PR
  • SeekableStreamIndexTaskTuningConfig

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@georgew5656 georgew5656 merged commit 428f58c into apache:master Sep 11, 2024
@georgew5656
Copy link
Copy Markdown
Contributor Author

the failing unit test seems to be unrelated, so i'm merging this

@adarshsanjeev adarshsanjeev added this to the 32.0.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants