Support maxColumnsToMerge in supervisor tuningConfig#17030
Merged
georgew5656 merged 5 commits intoapache:masterfrom Sep 11, 2024
Merged
Support maxColumnsToMerge in supervisor tuningConfig#17030georgew5656 merged 5 commits intoapache:masterfrom
georgew5656 merged 5 commits intoapache:masterfrom
Conversation
suneet-s
approved these changes
Sep 11, 2024
Contributor
Author
|
the failing unit test seems to be unrelated, so i'm merging this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The StreamAppenderator already supports using maxColumnsToMerge from tuningConfig, the only thing preventing this property from being used is the supervisor/streaming task specs not supporting it.
It would be nice if we could automatically set the value like in MSQE but for now, just let the user specify the value (defaults to -1 which is current behavior).
Release note
Key changed/added classes in this PR
SeekableStreamIndexTaskTuningConfigThis PR has: