Provide chmod command for -XX:OnOutOfMemoryError from shell script#17054
Merged
abhishekrb19 merged 5 commits intoapache:masterfrom Sep 13, 2024
Merged
Provide chmod command for -XX:OnOutOfMemoryError from shell script#17054abhishekrb19 merged 5 commits intoapache:masterfrom
chmod command for -XX:OnOutOfMemoryError from shell script#17054abhishekrb19 merged 5 commits intoapache:masterfrom
Conversation
A bug in Intellij that doesn't parse the chmod command line correctly.
gianm
approved these changes
Sep 12, 2024
…level.
Fixes the following error:
/home/runner/work/druid/druid/dev/chmod-heap-dumps.sh: line 19: ${project.parent.basedir}/target/*.hprof: bad substitution
pranavbhole
pushed a commit
to pranavbhole/druid
that referenced
this pull request
Sep 17, 2024
apache#17054) A command line arg -XX:OnOutOfMemoryError='chmod 644 ${project.parent.basedir}/target/*.hprof' was added to collect heap dumps: apache#17029 This arg is causing problems when running tests from Intellij. Intellij doesn't seem to likechmod 644, but this command works as expected in mvn. So as a workaround, add the chmod 644 ${BASE_DIR/target/*.hprof' command in a shell script that can then be executed when OnOutOfMemoryError happens to make Intellij happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A command line arg
-XX:OnOutOfMemoryError='chmod 644 ${project.parent.basedir}/target/*.hprof'was added to collect heap dumps: #17029This arg is causing problems when running tests from Intellij. Intellij doesn't seem to like
chmod 644, but this command works as expected inmvn. So as a workaround, add thechmod 644 ${BASE_DIR/target/*.hprof'command in a shell script that can then be executed whenOnOutOfMemoryErrorhappens to make Intellij happy.Verified that I'm able to run tests on Intellij successfully on reimporting pom.xml with this change.