Handle memory leaks from Mockito inline mocks#17070
Merged
gianm merged 1 commit intoapache:masterfrom Sep 15, 2024
Merged
Conversation
gianm
approved these changes
Sep 15, 2024
kgyrtkirk
reviewed
Sep 18, 2024
| @AfterEach | ||
| public void tearDown2() | ||
| { | ||
| Mockito.framework().clearInlineMocks(); |
Member
There was a problem hiding this comment.
I don't think this leak-like usage is msq specific ; it could possibly be added to CalciteTestBase so that all Calcite*Test excercise this call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In #17056, we increased the test JVM max heap from 2 GB to 2.5 GB as we were running into OOM issues in some tests. It was a temporary measure to unblock the CI/CD pipeline.
On digging into the heap dump, the issue seems similar to mockito/mockito#2503, and the suggestion was to use
Mockito.framework().clearInlineMocks().This PR adds
Mockito.framework().clearInlineMocks()toMSQTestBase#AfterEachto handle the memory leaks from Mockito's inline mocks, and reduces the test JVM max heap back to 2 GB.This PR has: