Skip to content

Make sketch encoding configurable#17086

Merged
adarshsanjeev merged 2 commits intoapache:masterfrom
adarshsanjeev:configurable-sketch-encoding
Sep 25, 2024
Merged

Make sketch encoding configurable#17086
adarshsanjeev merged 2 commits intoapache:masterfrom
adarshsanjeev:configurable-sketch-encoding

Conversation

@adarshsanjeev
Copy link
Copy Markdown
Contributor

@adarshsanjeev adarshsanjeev commented Sep 17, 2024

Makes sketch encoding in MSQ configurable by the user. This would allow a user to configure the sketch encoding method for a specific query.

The default is octet stream encoding.

Release notes

  • Add a sketchEncoding query context parameter that controls the sketch encoding format between workers in MSQ. Allowed values are JSON or OCTET_STREAM. The default value is OCTET_STREAM.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions Bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Sep 17, 2024
@cryptoe cryptoe added this to the 31.0.0 milestone Sep 24, 2024
@adarshsanjeev adarshsanjeev merged commit 464b153 into apache:master Sep 25, 2024
adarshsanjeev added a commit to adarshsanjeev/druid that referenced this pull request Sep 25, 2024
Makes sketch encoding in MSQ configurable by the user. This would allow a user to configure the sketch encoding method for a specific query.

The default is octet stream encoding.
kfaraz pushed a commit to kfaraz/druid that referenced this pull request Sep 30, 2024
Makes sketch encoding in MSQ configurable by the user. This would allow a user to configure the sketch encoding method for a specific query.

The default is octet stream encoding.
kfaraz pushed a commit that referenced this pull request Sep 30, 2024
Makes sketch encoding in MSQ configurable by the user. This would allow a user to configure the sketch encoding method for a specific query.

The default is octet stream encoding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants