Skip to content

Window Functions : Improve performance by comparing Strings in frame bytes without converting them #17091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgyrtkirk merged 6 commits into from
Sep 19, 2024
Merged

Window Functions : Improve performance by comparing Strings in frame bytes without converting them #17091

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1a62cef
try out
sreemanamala Sep 17, 2024
0436a1a
Merge branch 'master' into win-perf
sreemanamala Sep 17, 2024
acfea8b
compare Strings without conversion
sreemanamala Sep 17, 2024
0045843
disable subqueryBytes
sreemanamala Sep 17, 2024
3c6b8d1
fix
sreemanamala Sep 18, 2024
406d3a7
simplify
sreemanamala Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion benchmarks/src/test/java/org/apache/druid/benchmark/query/SqlWindowFunctionsBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,12 @@ public int getNumMergeBuffers()
{
return 3;
}

@Override
public int intermediateComputeSizeBytes()
{
return 200_000_000;
}
};

@Setup(Level.Trial)
Expand Down Expand Up @@ -336,7 +342,8 @@ public void querySql(String sql, Blackhole blackhole)
{
final Map<String, Object> context = ImmutableMap.of(
PlannerContext.CTX_ENABLE_WINDOW_FNS, true,
QueryContexts.MAX_SUBQUERY_BYTES_KEY, "auto"
QueryContexts.MAX_SUBQUERY_BYTES_KEY, "disabled",
QueryContexts.MAX_SUBQUERY_ROWS_KEY, -1
);
try (final DruidPlanner planner = plannerFactory.createPlannerForTesting(engine, sql, context)) {
final PlannerResult plannerResult = planner.plan();
Expand Down Expand Up @@ -420,4 +427,15 @@ public void windowWithoutSorter(Blackhole blackhole)
+ "GROUP BY dimUniform, dimSequential";
querySql(sql, blackhole);
}

@Benchmark
public void windowWithGroupbyTime(Blackhole blackhole)
{
String sql = "SELECT "
+ "SUM(dimSequentialHalfNull) + SUM(dimHyperUnique), "
+ "LAG(SUM(dimSequentialHalfNull + dimHyperUnique)) OVER (PARTITION BY dimUniform ORDER BY dimSequential) "
+ "FROM foo "
+ "GROUP BY __time, dimUniform, dimSequential";
querySql(sql, blackhole);
}
}
7 changes: 7 additions & 0 deletions processing/src/main/java/org/apache/druid/frame/read/columnar/StringFrameColumnReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
package org.apache.druid.frame.read.columnar;

import com.google.common.primitives.Ints;
import org.apache.commons.lang.ObjectUtils;
import org.apache.datasketches.memory.Memory;
import org.apache.druid.common.config.NullHandling;
import org.apache.druid.error.DruidException;
Expand Down Expand Up @@ -507,6 +508,12 @@ protected Comparator<Object> getComparator()
return Comparator.nullsFirst(Comparator.comparing(o -> ((String) o)));
}

@Override
public int compareRows(int rowNum1, int rowNum2)
{
return ObjectUtils.compare(getStringUtf8(rowNum1), getStringUtf8(rowNum2));
}

/**
* Returns a ByteBuffer containing UTF-8 encoded string number {@code index}. The ByteBuffer is always newly
* created, so it is OK to change its position, limit, etc. However, it may point to shared memory, so it is
Expand Down