Joins can take forever to finish on historicals without ever timing out.#17099
Merged
kgyrtkirk merged 1 commit intoapache:masterfrom Sep 19, 2024
Merged
Joins can take forever to finish on historicals without ever timing out.#17099kgyrtkirk merged 1 commit intoapache:masterfrom
kgyrtkirk merged 1 commit intoapache:masterfrom
Conversation
kgyrtkirk
approved these changes
Sep 18, 2024
Member
kgyrtkirk
left a comment
kgyrtkirk
left a comment
There was a problem hiding this comment.
I wonder if there are any benchmarks for this - if none then I think its better to not take the risk here
LakshSingla
approved these changes
Sep 19, 2024
kfaraz
pushed a commit
to kfaraz/druid
that referenced
this pull request
Sep 30, 2024
kfaraz
added a commit
that referenced
this pull request
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This screenshot is of a processing thread that keeps running, hogging the CPU well beyond the configured timeout because PostJoinCursor is not interruptible. This PR fixes the problem by always allowing interruptions when PostJoinCursor is in play.