Rewrite SQL node early in the planning phase to support parameterization of MSQ DML queries#17126
Merged
abhishekrb19 merged 1 commit intoapache:masterfrom Sep 23, 2024
Merged
Conversation
|
|
||
| @MethodSource("data") | ||
| @ParameterizedTest(name = "{index}:with context {0}") | ||
| public void testReplaceWithDynamicParameters(String contextName, Map<String, Object> context) |
Check notice
Code scanning / CodeQL
Useless parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's useful to supply dynamic parameters to automate periodic jobs. However, previously only MSQ
SELECTqueries could be parameterized. For example, consider the following MSQREPLACEquery with valid dynamic parameters:[ { "type": "TIMESTAMP", "value": "2023-01-01" }, { "type": "TIMESTAMP", "value": "2023-01-05" }, ]The expectation is that the parameters will bind to the
?placeholders in the query in place of the literal, but the query fails with the following exception:This is because there is a bunch of validation in the
IngestHandlercode that happens during the planning stage, which runs on the node where the rewrite hasn’t happened yet. This change moves the call torewriteParameters()earlier in the planning stage so any validations will run on the rewritten root node.This PR has: