Skip to content

Web console: switch to using arrays by default #17133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogievetsky merged 1 commit into from
Sep 24, 2024
Merged

Web console: switch to using arrays by default #17133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,6 +296,9 @@ export type SchemaMode = 'fixed' | 'string-only-discovery' | 'type-aware-discove
export type ArrayMode = 'arrays' | 'multi-values';

export const DEFAULT_FORCE_SEGMENT_SORT_BY_TIME = true;
export const DEFAULT_SCHEMA_MODE: SchemaMode = 'fixed';
export const DEFAULT_ARRAY_MODE: ArrayMode = 'arrays';

export function getForceSegmentSortByTime(spec: Partial<IngestionSpec>): boolean {
return (
deepGet(spec, 'spec.dataSchema.dimensionsSpec.forceSegmentSortByTime') ??
Expand Down
6 changes: 4 additions & 2 deletions web-console/src/views/load-data-view/load-data-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,9 @@ import {
computeFlattenPathsForData,
CONSTANT_TIMESTAMP_SPEC,
CONSTANT_TIMESTAMP_SPEC_FIELDS,
DEFAULT_ARRAY_MODE,
DEFAULT_FORCE_SEGMENT_SORT_BY_TIME,
DEFAULT_SCHEMA_MODE,
DIMENSION_SPEC_FIELDS,
fillDataSourceNameIfNeeded,
fillInputFormatIfNeeded,
Expand Down Expand Up @@ -317,8 +319,8 @@ function initializeSchemaWithSampleIfNeeded(
spec,
sample,
DEFAULT_FORCE_SEGMENT_SORT_BY_TIME,
'fixed',
'multi-values',
DEFAULT_SCHEMA_MODE,
DEFAULT_ARRAY_MODE,
getRollup(spec, false),
);
}
Expand Down
3 changes: 2 additions & 1 deletion web-console/src/views/workbench-view/input-format-step/input-format-step.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import type { ArrayMode, InputFormat, InputSource } from '../../../druid-models'
import {
BATCH_INPUT_FORMAT_FIELDS,
chooseByBestTimestamp,
DEFAULT_ARRAY_MODE,
DETECTION_TIMESTAMP_SPEC,
getPossibleSystemFieldsForInputSource,
guessColumnTypeFromSampleResponse,
Expand Down Expand Up @@ -93,7 +94,7 @@ export const InputFormatStep = React.memo(function InputFormatStep(props: InputF
InputSourceAndFormat | undefined
>(isValidInputFormat(initInputFormat) ? inputSourceAndFormat : undefined);
const [selectTimestamp, setSelectTimestamp] = useState(true);
const [arrayMode, setArrayMode] = useState<ArrayMode>('multi-values');
const [arrayMode, setArrayMode] = useState<ArrayMode>(DEFAULT_ARRAY_MODE);

const [previewState] = useQueryManager<InputSourceAndFormat, SampleResponse>({
query: inputSourceAndFormatToSample,
Expand Down