use CastToObjectVectorProcessor for cast to string#17148
Merged
clintropolis merged 1 commit intoapache:masterfrom Sep 24, 2024
Merged
use CastToObjectVectorProcessor for cast to string#17148clintropolis merged 1 commit intoapache:masterfrom
clintropolis merged 1 commit intoapache:masterfrom
Conversation
gianm
approved these changes
Sep 24, 2024
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Sep 24, 2024
clintropolis
added a commit
that referenced
this pull request
Sep 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue noticed after #17098, where the
CastToStringVectorProcessorwasn't actually doing a cast, and instead just usingEvals.asString. This was fine when only numbers and strings were supported in vectorized expressions, but insufficient when arrays and complex types are allowed.The solution is just to remove
CastToStringVectorProcessorin favor of always usingCastToObjectVectorProcessor. Alternatively, we could have leftCastToObjectVectorProcessorto use in cases where we were casting from a numeric type, but that seems a bit confusing so I just removed it.