add multi-value string object vector matcher and expression vector object selectors#17162
Merged
clintropolis merged 1 commit intoapache:masterfrom Sep 26, 2024
Merged
Conversation
gianm
approved these changes
Sep 26, 2024
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Sep 26, 2024
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Sep 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue after #17098 that can occur with
array_to_mvfunction resulting from a couple of things happening. The first problem is thatVectorValueMatcherColumnProcessorFactorymethodmakeObjectProcessorhad special handling forSTRING, but not further specialization for when it was multi-valued. So, this PR addsMultiValueStringObjectVectorValueMatcherto handle cases where an object selector is asked for a multi-value string. Secondly, expression virtual columns were not expecting multi-value string expressions, soExpressionVectorSelectorshas been updated to check for array typed outputs but with a string type hint, and use a newly addedExpressionVectorMultiValueStringObjectSelectorwhich coerces the values multi-value style back intoListorStringas appropriate.Added tests also led to another bug being fixed when array_to_mv was used on a null array row.