fix string array grouping comparator#17183
Merged
LakshSingla merged 1 commit intoapache:masterfrom Oct 8, 2024
Merged
Conversation
LakshSingla
approved these changes
Sep 30, 2024
Contributor
LakshSingla
left a comment
LakshSingla
left a comment
There was a problem hiding this comment.
LGTM, wondering if we should make this change more generic
Comment on lines
+2200
to
+2205
| private static boolean useNaturalStringArrayComparator(@Nullable StringComparator stringComparator) | ||
| { | ||
| return stringComparator == null | ||
| || StringComparators.NATURAL.equals(stringComparator) | ||
| || StringComparators.LEXICOGRAPHIC.equals(stringComparator); | ||
| } |
Contributor
There was a problem hiding this comment.
Should the method DimensionComparisonUtils#isNaturalComparator need to be updated instead, since this looks like a generic bug that may exist if someone's using that method with array elements?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue that can occur when grouping on a string array and sorting by it, where we were not checking for the 'natural' comparator.