Skip to content

Fix bug with while adding DistinctSketches#17184

Merged
cryptoe merged 2 commits intoapache:masterfrom
adarshsanjeev:distinct-sketch-bug
Sep 30, 2024
Merged

Fix bug with while adding DistinctSketches#17184
cryptoe merged 2 commits intoapache:masterfrom
adarshsanjeev:distinct-sketch-bug

Conversation

@adarshsanjeev
Copy link
Copy Markdown
Contributor

Fix a bug where we incorrectly call retainedKeys.firstKey() twice while adding another sketch. This can sometimes throw an exception if there was only one key, and/or create an inaccurate estimate of the bytes retained.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@github-actions github-actions Bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Sep 30, 2024
@cryptoe cryptoe added this to the 31.0.0 milestone Sep 30, 2024
@cryptoe cryptoe merged commit 95fb813 into apache:master Sep 30, 2024
adarshsanjeev added a commit to adarshsanjeev/druid that referenced this pull request Sep 30, 2024
* Fix bug with checking the incorrect key

* Add tests
abhishekagarwal87 pushed a commit that referenced this pull request Sep 30, 2024
* Fix bug with checking the incorrect key

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants