Skip to content

[Backport] Add CursorHolder.isPreAggregated method to allow cursors on pre-aggregated data (#17058)#17205

Merged
kfaraz merged 1 commit intoapache:31.0.0from
kfaraz:backport_17058
Oct 1, 2024
Merged

[Backport] Add CursorHolder.isPreAggregated method to allow cursors on pre-aggregated data (#17058)#17205
kfaraz merged 1 commit intoapache:31.0.0from
kfaraz:backport_17058

Conversation

@kfaraz
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz commented Oct 1, 2024

changes:

  • CursorHolder.isPreAggregated method indicates that a cursor has pre-aggregated data for all AggregatorFactory specified in a CursorBuildSpec. If true, engines should rewrite the query to use AggregatorFactory.getCombiningAggreggator, and column selector factories will provide selectors with the aggregator interediate type for the aggregator factory name
  • Added groupby, timeseries, and topN support for CursorHolder.isPreAggregated
  • Added synthetic test since no CursorHolder implementations support isPreAggregated at this point in time

Fixes #XXXX.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

…gated data (apache#17058)

changes:
* CursorHolder.isPreAggregated method indicates that a cursor has pre-aggregated data for all AggregatorFactory specified in a CursorBuildSpec. If true, engines should rewrite the query to use AggregatorFactory.getCombiningAggreggator, and column selector factories will provide selectors with the aggregator interediate type for the aggregator factory name
* Added groupby, timeseries, and topN support for CursorHolder.isPreAggregated
* Added synthetic test since no CursorHolder implementations support isPreAggregated at this point in time
@kfaraz kfaraz added the Backport label Oct 1, 2024
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 1, 2024
@kfaraz kfaraz merged commit 9b192bd into apache:31.0.0 Oct 1, 2024
@kfaraz kfaraz deleted the backport_17058 branch October 1, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants