Skip to content

[Backport] MSQ: Fix calculation of suggested memory in WorkerMemoryParameters. (#17108)#17215

Merged
kfaraz merged 1 commit intoapache:31.0.0from
kfaraz:backport_17108
Oct 2, 2024
Merged

[Backport] MSQ: Fix calculation of suggested memory in WorkerMemoryParameters. (#17108)#17215
kfaraz merged 1 commit intoapache:31.0.0from
kfaraz:backport_17108

Conversation

@kfaraz
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz commented Oct 2, 2024

The "suggested server memory" figure needs to take into account maxConcurrentStages. The fix here does not affect the main memory calculations, but it does affect the accuracy of error messages.

Fixes #XXXX.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

…pache#17108)

The "suggested server memory" figure needs to take into account
maxConcurrentStages. The fix here does not affect the main memory
calculations, but it does affect the accuracy of error messages.
@kfaraz kfaraz added the Backport label Oct 2, 2024
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 2, 2024
@github-actions github-actions Bot added Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Oct 2, 2024
@kfaraz kfaraz changed the title MSQ: Fix calculation of suggested memory in WorkerMemoryParameters. (#17108) [Backport] MSQ: Fix calculation of suggested memory in WorkerMemoryParameters. (#17108) Oct 2, 2024
@kfaraz kfaraz merged commit cf44747 into apache:31.0.0 Oct 2, 2024
@kfaraz kfaraz deleted the backport_17108 branch October 2, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Backport

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants