Skip to content

[Backport] add substituteCombiningFactory implementations for datasketches aggs …#17323

Merged
kfaraz merged 1 commit intoapache:31.0.0from
kfaraz:backport_17314
Oct 10, 2024
Merged

[Backport] add substituteCombiningFactory implementations for datasketches aggs …#17323
kfaraz merged 1 commit intoapache:31.0.0from
kfaraz:backport_17314

Conversation

@kfaraz
Copy link
Copy Markdown
Contributor

@kfaraz kfaraz commented Oct 10, 2024

Follow up to #17214, adds implementations for substituteCombiningFactory so that more datasketches aggs can match projections, along with some projections tests for datasketches.

Fixes #XXXX.

Description

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

…pache#17314)

Follow up to apache#17214, adds implementations for substituteCombiningFactory so that more
datasketches aggs can match projections, along with some projections tests for datasketches.
@kfaraz kfaraz added this to the 31.0.0 milestone Oct 10, 2024
@kfaraz kfaraz merged commit 1a7f91f into apache:31.0.0 Oct 10, 2024
@kfaraz kfaraz deleted the backport_17314 branch October 10, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants