MSQ: Include stageId, workerNumber in processing thread names.#17324
Merged
gianm merged 2 commits intoapache:masterfrom Oct 11, 2024
Merged
MSQ: Include stageId, workerNumber in processing thread names.#17324gianm merged 2 commits intoapache:masterfrom
gianm merged 2 commits intoapache:masterfrom
Conversation
Helps identify which query was running in a thread dump.
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
abhishekrb19
approved these changes
Oct 10, 2024
| private static String cancellationIdFor(final StageId stageId, final int workerNumber) | ||
| { | ||
| return StringUtils.format("%s_%s", stageId, workerNumber); | ||
| return StringUtils.format("dart-worker[%s_%s]", stageId, workerNumber); |
Contributor
There was a problem hiding this comment.
Is this useful for non-Dart workers too?
Contributor
Author
There was a problem hiding this comment.
Oops, this should say msq-worker, not dart-worker, since this isn't Dart specific code. Updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps identify which query was running in a thread dump.