Prioritize query stats in RequestLogLine.getNativeQueryLine#17326
Merged
cryptoe merged 1 commit intoapache:masterfrom Dec 13, 2024
Merged
Prioritize query stats in RequestLogLine.getNativeQueryLine#17326cryptoe merged 1 commit intoapache:masterfrom
cryptoe merged 1 commit intoapache:masterfrom
Conversation
findingrish
approved these changes
Oct 21, 2024
Contributor
findingrish
left a comment
There was a problem hiding this comment.
LGTM, please rebase to re-trigger the build.
Contributor
|
@Zeyu-Chen-SFDC Could you please fix CI ? |
14fb6c2 to
64a79ce
Compare
Author
|
@cryptoe |
Contributor
|
@Zeyu-Chen-SFDC Thanks for the contribution to Apache Druid. Looking forward to many more 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change switches the order of query vs stats in
getNativeQueryLineto keep it consistent withgetSqlQueryLine.It happens on non-trivial occasions when a long list of
intervals.segmentsin the query object exceeds the max cut-off of whichever logging system is deployed by the user and makes the stats unavailable for subsequent log searches. In those situations, we prefer to have the more important stats logged first and sacrifice the list of intervals.The same change should be applied to the order of fields in the native query object, moving
intervalsto the last. However, that's a bigger change.Release note
Key changed/added classes in this PR
RequestLogLineThis PR has: