Skip to content

Remove EOL file-loader dependency#17346

Merged
vogievetsky merged 1 commit intoapache:masterfrom
confluentinc:file-loader-vulnerability-apache
Oct 16, 2024
Merged

Remove EOL file-loader dependency#17346
vogievetsky merged 1 commit intoapache:masterfrom
confluentinc:file-loader-vulnerability-apache

Conversation

@suraj-goel
Copy link
Copy Markdown
Contributor

@suraj-goel suraj-goel commented Oct 15, 2024

Fixes #17338.

Description

Testing

  • Deployed Druid cluster on local using Docker
  • Deployed web console app by using:
    • npm install
    • npm run compile
    • npm start
  • Sanity tested the local web console

Fixed the bug ...

Renamed the class ...

Added a forbidden-apis entry ...

Release note


Key changed/added classes in this PR
  • MyFoo
  • OurBar
  • TheirBaz

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@suraj-goel suraj-goel marked this pull request as ready for review October 15, 2024 06:16
Copy link
Copy Markdown
Contributor

@vogievetsky vogievetsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you

@vogievetsky vogievetsky merged commit c1fe1ac into apache:master Oct 16, 2024
@adarshsanjeev adarshsanjeev added this to the 32.0.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix EOL npm:file-loader:6.2.0 in Web Console

3 participants