Skip to content

Fixing pip installation after ubuntu upgrade#17358

Merged
abhishekrb19 merged 1 commit intoapache:masterfrom
pranavbhole:fixingPipAfterUbuntu24
Oct 16, 2024
Merged

Fixing pip installation after ubuntu upgrade#17358
abhishekrb19 merged 1 commit intoapache:masterfrom
pranavbhole:fixingPipAfterUbuntu24

Conversation

@pranavbhole
Copy link
Copy Markdown
Contributor

@pranavbhole pranavbhole commented Oct 15, 2024 •
edited
Loading

Fixing pip installation after Ubuntu-latest tag update in GHA runners.

Creating python virtual env to install required custom packages.

actions/runner-images#10636
actions/runner-images#10783

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@pranavbhole pranavbhole marked this pull request as ready for review October 15, 2024 22:54
@github-actions github-actions Bot added the GHA label Oct 15, 2024
imply-elliott
imply-elliott approved these changes Oct 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@imply-elliott imply-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚂

abhishekrb19
abhishekrb19 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@abhishekrb19 abhishekrb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing our CI pipeline, @pranavbhole!

@abhishekrb19 abhishekrb19 merged commit f80e2c2 into apache:master Oct 16, 2024
ac9817 pushed a commit to ac9817/druid that referenced this pull request Oct 16, 2024
@pranavbhole
Fix pip installation after ubuntu upgrade (apache#17358)
9d86763
abhishekagarwal87 pushed a commit that referenced this pull request Oct 16, 2024
@pranavbhole @abhishekagarwal87
Fix pip installation after ubuntu upgrade (#17358)
9dac0f7
suneet-s pushed a commit that referenced this pull request Oct 17, 2024
@ac9817 @pranavbhole
supervisor/autoscaler: Fix clearing of collected lags on skipped scal…
e834e49 
…e actions (#17356)

* superviosr/autoscaler: Fix clearing of collected lags on skipped scale actions

* comments

* supervisor/autoscaler: Skip scaling when partitions are less than minTaskCount (#17335)

* Fix pip installation after ubuntu upgrade (#17358)

* fix tests

---------

Co-authored-by: Pranav <pranavbhole@gmail.com>
@adarshsanjeev adarshsanjeev added this to the 32.0.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhishekrb19 abhishekrb19 abhishekrb19 approved these changes

+1 more reviewer

@imply-elliott imply-elliott imply-elliott approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Development Blocker GHA

Projects

None yet

Milestone

32.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pranavbhole @abhishekrb19 @imply-elliott @adarshsanjeev