Add benchmark suite for MSQ window functions#17377
Conversation
adarshsanjeev
left a comment
There was a problem hiding this comment.
Overall, this looks good to me. Few comments.
| runStep.run(); | ||
| } | ||
|
|
||
| BaseExecuteQuery execStep = (BaseExecuteQuery) runSteps.get(runSteps.size() - 1); |
There was a problem hiding this comment.
I'm not very familiar with this, why is the change required to run all runsteps for this benchmark (and not others)?
There was a problem hiding this comment.
queryTestBuilder.results() didn't support MSQ apparently, since it only had the execute step, and not the ExtractResultsFactory step.
So, without this change, instead of getting the query results, we were getting the query ID. The ExtractResultsFactory step (added as a custom runner when declaring QueryTestBuilder) takes the query ID, and contacts the overlord client, and fetches the actual results.
(and not others)?
In the regular MSQ tests, we do testBuilder().run() which handled both steps already.
* Add benchmark suite for MSQ window functions * Fix inspection checks * Address review comment: Rename method
Description
This PR adds a benchmark suite for MSQ window function queries.
A sample run on my local gave the following results:
(Note: The above run was done with the changes of #17373, as otherwise I was running into the
Channel has no capacityissue)This PR has: