Closed
Conversation
changes: * fix issue when merging projections from multiple-incremental persists which was hoping that some 'dim conversion' buffers were not closed, but they already were (by the merging iterator). fix involves recreating the merging iterator to rebuild the dim conversions, which is sad, but maybe better than keeping the buffers open for the entire lifetime of the segment writeout * fix queryable index projection to not put the time-like column as a dimension, instead only adding it as __time
gianm
reviewed
Oct 29, 2024
| getDictionaryMergingComparator(), | ||
| true | ||
| ); | ||
| // iterate through merger to build dim conversions.. this is gross, but the alternative is holding open dim |
Contributor
There was a problem hiding this comment.
would it make sense to write the conversions to a tmp file rather than holding buffers open or recomputing them?
Member
Author
There was a problem hiding this comment.
ah yea, that makes sense, will explore that, already do something similar for the value dictionaries for nested columns. Do you think we should only do this if a column is used as a parent or would it be ok to just do always?
Contributor
There was a problem hiding this comment.
Probably only if it's used as a parent? Just to avoid using disk needlessly otherwise.
Member
Author
|
closing in favor of #17460 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes: