use big endian for compressed complex column values to fit ObjectStrategy expectations#17422
Merged
gianm merged 1 commit intoapache:masterfrom Oct 29, 2024
Merged
Conversation
…ategy expectations
gianm
approved these changes
Oct 29, 2024
jtuglu1
pushed a commit
to jtuglu1/druid
that referenced
this pull request
Nov 20, 2024
…ategy expectations (apache#17422)
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Nov 22, 2024
…ategy expectations (apache#17422)
clintropolis
added a commit
to clintropolis/druid
that referenced
this pull request
Nov 22, 2024
…ategy expectations (apache#17422)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Less ambitious fix than #17391, which adds the concept of value byte ordering to
ObjectStrategy, this PR instead just hard-codesCompressedComplexColumnto use big endian value buffers in order to fix an issue related to value endianness with someObjectStrategyimplementations when used with the compression added in #16863.I would still like to do the changes in the other PR at some point because it is a path to allowing all the stuff in segments to use native endian, but there are a lot of additional changes which need to be done first, such as squaring up the things that use
ByteBufferWriter/ObjectStrategy.fromByteBufferWithSizeto determine if the header (size) int value endian should match the endian of the object strategy or not, and determining a more elegant way to handle this stuff.Release note
Fixes an issue related to value buffers being ordered with the incorrect endianness which can cause some complex types, such as
approxHistogramto incorrectly be read, and can lead to out of memory exceptions in some cases.This PR has: