Run JDK 21 workflows with 21.0.4.#17458
Merged
gianm merged 3 commits intoapache:masterfrom Nov 7, 2024
Merged
Conversation
To work around apache#17429, run our JDK 21 workflows with version 21.0.4. It does not appear to have this problem.
cryptoe
approved these changes
Nov 7, 2024
abhishekrb19
approved these changes
Nov 7, 2024
| fail-fast: false | ||
| matrix: | ||
| jdk: [8, 17, 21] | ||
| jdk: ['8', '17', '21.0.4'] |
Contributor
There was a problem hiding this comment.
May want to update this check as well with the more specific 21.0.4 JDK version - https://github.com/apache/druid/blob/master/integration-tests/script/docker_build_containers.sh#L29
Member
There was a problem hiding this comment.
that image is not affected as its runs a pretty old version:
savara:~$ docker run --rm -it openjdk:21-slim-buster /bin/bash -c 'java -version'
openjdk version "21-ea" 2023-09-19
OpenJDK Runtime Environment (build 21-ea+26-2328)
OpenJDK 64-Bit Server VM (build 21-ea+26-2328, mixed mode, sharing)
I don't see any more recent images here
so I think we should leave this as-is for now...
Member
There was a problem hiding this comment.
I've unpatched this file for now - wdyt?
Contributor
There was a problem hiding this comment.
Sounds reasonable to me
Contributor
Author
|
The JDK 21 unit tests passed. I've added some comments to link back to #17429 and pushed again. If they pass again, that's a good sign, and I'll merge this. |
jtuglu1
pushed a commit
to jtuglu1/druid
that referenced
this pull request
Nov 20, 2024
* Run JDK 21 workflows with 21.0.4. To work around apache#17429, run our JDK 21 workflows with version 21.0.4. It does not appear to have this problem. * Undo changes in standard-its.yml * Add comments. --------- Co-authored-by: Zoltan Haindrich <kirk@rxd.hu>
clintropolis
pushed a commit
to clintropolis/druid
that referenced
this pull request
Nov 22, 2024
* Run JDK 21 workflows with 21.0.4. To work around apache#17429, run our JDK 21 workflows with version 21.0.4. It does not appear to have this problem. * Undo changes in standard-its.yml * Add comments. --------- Co-authored-by: Zoltan Haindrich <kirk@rxd.hu>
clintropolis
added a commit
that referenced
this pull request
Nov 22, 2024
* Run JDK 21 workflows with 21.0.4. To work around #17429, run our JDK 21 workflows with version 21.0.4. It does not appear to have this problem. * Undo changes in standard-its.yml * Add comments. --------- Co-authored-by: Gian Merlino <gianmerlino@gmail.com> Co-authored-by: Zoltan Haindrich <kirk@rxd.hu>
gianm
added a commit
to gianm/druid
that referenced
this pull request
Feb 3, 2025
Reverts PR apache#17458.
clintropolis
pushed a commit
that referenced
this pull request
Feb 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To work around #17429, run our JDK 21 workflows with version 21.0.4. It does not appear to have this problem.