ScanQuery should not ignore columnTypes in equals/hashCode#17463
Merged
cryptoe merged 60 commits intoapache:masterfrom Nov 12, 2024
Merged
ScanQuery should not ignore columnTypes in equals/hashCode#17463cryptoe merged 60 commits intoapache:masterfrom
cryptoe merged 60 commits intoapache:masterfrom
Conversation
github-actions
Bot
added
Area - Batch Ingestion
Area - Querying
Area - MSQ
rohangarg
approved these changes
Nov 12, 2024
Member
rohangarg
left a comment
rohangarg
left a comment
There was a problem hiding this comment.
LGTM - thanks for the changes @kgyrtkirk 👍
jtuglu1
pushed a commit
to jtuglu1/druid
that referenced
this pull request
Nov 20, 2024
) * ScanQuery: equals/hashCode/toString * DruidQuery: changes of Align ScanQuery column order with its desired signature apache#17457 * ScanQueryTest: add equalsverifer test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
columnTypeswas introduced it was not added toequals/hashCodeScanQueryrelated change: Align ScanQuery column order with its desired signature #17457important changed files:
ScanQuery: equals/hashCode/toStringDruidQuery: changes of Align ScanQuery column order with its desired signature #17457ScanQueryTest: add equalsverifer testall other changes are due to column order/columnTypes