Remove intellij-inspections check from CI#17469
Merged
cryptoe merged 5 commits intoapache:masterfrom Nov 13, 2024
Merged
Conversation
Contributor
|
Why do we need to remove these files Folks should be able to run intellij inspections locally if they want to. |
This reverts commit 81e20c8.
cryptoe
reviewed
Nov 13, 2024
Contributor
cryptoe
left a comment
There was a problem hiding this comment.
Lets not remove the .idea files.
cryptoe
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We plan to deprecate Java 8 as part of #17466. We ran into some issues with
intellij-inspectionscheck while doing that.On further discussion, we decided that we should remove intellij-inspections check for the following reasons:
intellij-inspectionsis coming from https://github.com/ccaominh/intellij-inspect, which is tied down toopenjdk8image.intellij-inspectis published at https://hub.docker.com/r/ccaominh/intellij-inspect, which is outside of Apache infra.maven-checkstyle-pluginandspotbugs) integrated in our CI pipeline which makes theintellij-inspectionscheck redundant for the most part.On further looking into point (4), the
intellij-inspectionscheck does seem to provide some useful checks which aren't being covered in other static checks we have at the moment.So the plan is:
intellij-inspectionscheck.intellij-inspectionscheck.This PR has: