Allow ForkingTaskRunner javaOpts to have quoted arguments which contain spaces#1748
Merged
himanshug merged 1 commit intoapache:masterfrom Sep 22, 2015
Merged
Conversation
drcrallen
force-pushed
the
forkingJavaOptionsWithQuotes
branch
2 times, most recently
from
c80025d to
03ece75
Compare
Contributor
There was a problem hiding this comment.
came across http://stackoverflow.com/a/19946701 , seems simpler ... see if it makes sense to use the CharMatcher.
Contributor
Author
There was a problem hiding this comment.
Tweaked with it a tiny bit, and changed some of the unit tests. Overall I think it is cleaner.
drcrallen
force-pushed
the
forkingJavaOptionsWithQuotes
branch
2 times, most recently
from
30bc257 to
43d2d01
Compare
Contributor
There was a problem hiding this comment.
it is non trivial to understand why this throws AssertionError and testPatternMatcherPreservesNonBreakingSpacesJavaOptions() does not. can you pls add some more comments?
or in the other test can you put the non-breaking character used in the comment
Contributor
Author
There was a problem hiding this comment.
Will add comments.
Contributor
Author
There was a problem hiding this comment.
Hopefully more clear now.
drcrallen
force-pushed
the
forkingJavaOptionsWithQuotes
branch
from
43d2d01 to
479dadf
Compare
drcrallen
force-pushed
the
forkingJavaOptionsWithQuotes
branch
from
479dadf to
465035e
Compare
Member
|
👍 |
Contributor
Author
|
|
himanshug
added a commit
that referenced
this pull request
Sep 22, 2015
Allow ForkingTaskRunner javaOpts to have quoted arguments which contain spaces
This was referenced Oct 14, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not currently possible to pass java options to the peons for items like
-XX:OnOutOfMemoryError="kill -9 %p"this PR is intended to allow such options to be passed to the peons.