Web console: refactor and improve the segment timeline (try 2)#17521
Merged
vogievetsky merged 6 commits intoapache:masterfrom Nov 28, 2024
Merged
Web console: refactor and improve the segment timeline (try 2)#17521vogievetsky merged 6 commits intoapache:masterfrom
vogievetsky merged 6 commits intoapache:masterfrom
Conversation
clintropolis
approved these changes
Nov 27, 2024
| export type RoundFn = (dt: Date, roundTo: number, tz: string) => Date; | ||
|
|
||
| export interface TimeShifterNoCeil { | ||
| canonicalLength: number; |
Member
There was a problem hiding this comment.
nit: should it be more obvious that this number is millis?
Contributor
Author
There was a problem hiding this comment.
in general in JS any number time related is assumed to be in ms unless stated otherwise
…render.tsx Co-authored-by: Clint Wylie <cjwylie@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #17508 for review. The original PR was merged by mistake and was immediately reverted.
Make the segment timeline more interactive and not have it force bucketing the segments to day granularity.
After
Before
Also
@druid-toolkit/queryto its renewed home ofdruid-query-toolkitmomentandmoment-timezone, use@internationalized/dateinstead+ INTERVAL 5 MINUTESwhere the units are pluralUNNESTto auto complete suggetionsgetApiArrayand use it everywhere<) and greater than (>) filter modes for tables