Fix cron job ITs by using jdk17 as the runtime_jdk#17544
Merged
abhishekrb19 merged 3 commits intoapache:masterfrom Dec 6, 2024
Merged
Fix cron job ITs by using jdk17 as the runtime_jdk#17544abhishekrb19 merged 3 commits intoapache:masterfrom
abhishekrb19 merged 3 commits intoapache:masterfrom
Conversation
abhishekrb19
reviewed
Dec 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since #17466, the cron job ITs have been broken because they use
runtime_jdk: 21.0.4: https://github.com/apache/druid/actions/runs/12078401498/job/33683001077.Error:
This is because docker_build_containers.sh is checking for Java version 21, but we are using 21.0.4, and hence it errors out.
Adding 21.0.4 in the if-condition won't help, since there's no
openjdk:21.0.4-slim-busterimage.This PR changes
runtime_jdkto17to fix the cron job ITs for now. We can revisit this later on exploring other possible options for which docker image to use for 21.0.4.This PR has: