Skip to content

Re-visit previously disabled spotbugs patterns and enable them#17560

Merged
kgyrtkirk merged 7 commits intoapache:masterfrom
Akshat-Jain:akshat/add-back-spotbugs-patterns
Dec 13, 2024
Merged

Re-visit previously disabled spotbugs patterns and enable them#17560
kgyrtkirk merged 7 commits intoapache:masterfrom
Akshat-Jain:akshat/add-back-spotbugs-patterns

Conversation

@Akshat-Jain
Copy link
Copy Markdown
Contributor

Description

With #17466, we excluded a bunch of spotbugs patterns to avoid irrelevant changes to that PR, and decided to revisit them as a follow-up action item.

This PR re-visits all the spotbugs patterns we disabled at that time, and enables some of them. The ones which are still kept disabled are mostly either false alarms, or would require a wider scoped design change.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Comment thread processing/src/main/java/org/apache/druid/query/aggregation/Histogram.java Outdated
Copy link
Copy Markdown
Member

@kgyrtkirk kgyrtkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 (pending tests)

@kgyrtkirk kgyrtkirk merged commit fed3684 into apache:master Dec 13, 2024
@adarshsanjeev adarshsanjeev added this to the 32.0.0 milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants