Re-visit previously disabled spotbugs patterns and enable them#17560
Merged
kgyrtkirk merged 7 commits intoapache:masterfrom Dec 13, 2024
Merged
Re-visit previously disabled spotbugs patterns and enable them#17560kgyrtkirk merged 7 commits intoapache:masterfrom
kgyrtkirk merged 7 commits intoapache:masterfrom
Conversation
kgyrtkirk
reviewed
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With #17466, we excluded a bunch of spotbugs patterns to avoid irrelevant changes to that PR, and decided to revisit them as a follow-up action item.
This PR re-visits all the spotbugs patterns we disabled at that time, and enables some of them. The ones which are still kept disabled are mostly either false alarms, or would require a wider scoped design change.
This PR has: