Conversation
| } else { | ||
| // Ignore this skipInterval | ||
| log.warn( | ||
| log.debug( |
There was a problem hiding this comment.
this log doesn't provide much useful info and can remain a debug
| new TypeReference<List<DataSegmentChangeRequest>>() | ||
| { | ||
| }; | ||
| new TypeReference<>() {}; |
There was a problem hiding this comment.
Java 9+ supports diamond operator with anonymous classes.
Since we have dropped support for Java 8, we can use this syntax here (and in several other places in the code which can be done in a separate PR).
cc: @Akshat-Jain
There was a problem hiding this comment.
Have raised PR: #17567. The PR isn't limited to just anonymous class usages, but rather does it for all usages where explicit type argument was redundant. I don't see an easy way to identify usages only for anonymous classes, and I didn't see any reason why we shouldn't do it for other usages as well, so ended up doing that. Hope that works!
Appreciate your review on the PR, thanks!
| log.info("Cancelled [%d] requests queued on server [%s].", queuedSegments.size(), serverId); | ||
| if (!queuedSegments.isEmpty()) { | ||
| queuedSegments.forEach(holder -> onRequestCompleted(holder, RequestStatus.CANCELLED)); | ||
| log.info("Cancelled [%d] requests queued on server[%s].", queuedSegments.size(), serverId); |
There was a problem hiding this comment.
log only when non-empty.
|
IT failures are unrelated. |
4 participants
No description provided.