Skip to content

Use GraalJS to execute javascript backed selector strategies#17843

Merged
cryptoe merged 15 commits intoapache:masterfrom
kgyrtkirk:try_graal
Apr 1, 2025
Merged

Use GraalJS to execute javascript backed selector strategies#17843
cryptoe merged 15 commits intoapache:masterfrom
kgyrtkirk:try_graal

Conversation

@kgyrtkirk
Copy link
Copy Markdown
Member

@kgyrtkirk kgyrtkirk commented Mar 28, 2025

This is an alternate approach to fix the selectors similarily to: #14795

This PR adds GraalJS - and configures the system to use that instead of the previously jdk built-in nashorn engine.

Incorporating Nashorn into the project would be more complicated as it would (beyond other thing) would require the end user to manually install it (its also not that much maintained)

Release note

Added GraalJS to enable back javascript backed selector strategies support out of the box.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • been tested in a test Druid cluster.

@kgyrtkirk kgyrtkirk changed the title Try graal Use GraalJS to execute javascript backed selector strategies Apr 1, 2025
@cryptoe
Copy link
Copy Markdown
Contributor

cryptoe commented Apr 1, 2025

@kgyrtkirk The CI failures look legit though .

@cryptoe cryptoe merged commit f042a36 into apache:master Apr 1, 2025
76 checks passed
@cryptoe cryptoe added this to the 33.0.0 milestone Apr 1, 2025
Copy link
Copy Markdown
Contributor

@maytasm maytasm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for getting this over the line and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants