Skip to content

Web console: add turboLoadingNodes#17860

Merged
vogievetsky merged 8 commits intoapache:masterfrom
vogievetsky:add_turboLoadingNodes_to_console
Apr 2, 2025
Merged

Web console: add turboLoadingNodes#17860
vogievetsky merged 8 commits intoapache:masterfrom
vogievetsky:add_turboLoadingNodes_to_console

Conversation

@vogievetsky
Copy link
Copy Markdown
Contributor

The web console follow up to #17775

image

@vogievetsky vogievetsky added this to the 33.0.0 milestone Apr 1, 2025
capistrant
capistrant previously approved these changes Apr 1, 2025
Copy link
Copy Markdown
Contributor

@capistrant capistrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the CI is broken cuz of docusaurus upgrade which is being looked into separately... upon further review maybe merging latest master into your branch would give better idea on the CI fail. I think your branch is behind master a bit and missing the docusaurus change all together.

@capistrant capistrant self-requested a review April 1, 2025 22:41
@capistrant capistrant dismissed their stale review April 1, 2025 22:41

Looks like the failing CI step is important for web-console so maybe we should fix before approval.

@capistrant
Copy link
Copy Markdown
Contributor

@cryptoe if we are wanting to call this out as experimental for druid 33, do we also need to update https://github.com/apache/druid/blob/master/docs/configuration/index.md to say the same in docs?

Copy link
Copy Markdown
Member

@kgyrtkirk kgyrtkirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@vogievetsky vogievetsky merged commit 77954f6 into apache:master Apr 2, 2025
10 checks passed
@vogievetsky vogievetsky deleted the add_turboLoadingNodes_to_console branch April 2, 2025 22:56
@cryptoe
Copy link
Copy Markdown
Contributor

cryptoe commented Apr 3, 2025

@cryptoe if we are wanting to call this out as experimental for druid 33, do we also need to update https://github.com/apache/druid/blob/master/docs/configuration/index.md to say the same in docs?

Yup I think we should call it experimental in the docs as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants