Web console: support for supervisor based compaction (use new compaction APIs)#17862
Merged
kfaraz merged 13 commits intoapache:masterfrom Apr 3, 2025
Merged
Web console: support for supervisor based compaction (use new compaction APIs)#17862kfaraz merged 13 commits intoapache:masterfrom
kfaraz merged 13 commits intoapache:masterfrom
Conversation
kfaraz
reviewed
Apr 2, 2025
Contributor
There was a problem hiding this comment.
Thanks a lot for the changes, @vogievetsky !
I tried them out, looks good!
Note for follow up stuff (not necessarily needed in the upcoming Druid 33):
- Show history of cluster level compaction config (we might need a separate API for this)
- Show datasource compaction config dialog box on the supervisors page to edit compaction supervisors
- Add option to copy over coordinator-based datasource compaction config into supervisor-based
| min: 0, | ||
| }, | ||
| { | ||
| name: 'compactionPolicy.type', |
Contributor
There was a problem hiding this comment.
Can we add a label Compaction search policy for this? Currently it shows up as Type.
…ion-dynamic-config.tsx Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
gianm
approved these changes
Apr 2, 2025
kfaraz
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up PR to: #17834
This PR changes the console to use the new unified compaction APIs and adds the setting to switch supervisor based compaction on and off.