Merged
Conversation
kgyrtkirk
reviewed
May 16, 2025
Member
kgyrtkirk
left a comment
There was a problem hiding this comment.
I know you've just opened to run CI; but I wonder if this should be the path or not
kgyrtkirk
reviewed
May 27, 2025
Member
kgyrtkirk
left a comment
There was a problem hiding this comment.
looks good! left a bunch of comments but nothing really serious... mostly just questions/minor notices :)
kgyrtkirk
approved these changes
May 30, 2025
gianm
reviewed
May 30, 2025
cryptoe
approved these changes
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Presently,
DartResourceshandles DART queries, whileSqlResourcehandles sql native queries. This includes some Dart specific code which needs to be run for creating and cancelling queries.This PR aims to unify these interfaces by adding an "engine selector" to
SqlResourceto allow it to run native as well as Dart queries. This involves pushing any engine specific code into theSqlEngineand refactoring the Dart cancellation to be more generic.Release Notes
SqlResource.engineQueryContext parameter. The value can benativeormsq-dart. The value determines the engine used to run the query. The default value isnative.This PR has: