Skip to content

Fix class loading issue for AWS Glue catalog in Iceberg extension #18016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
a2l007 merged 2 commits into from
May 21, 2025
Merged

Fix class loading issue for AWS Glue catalog in Iceberg extension #18016

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
419bf4a
Fix class loading issue for glue catalog
a2l007 May 19, 2025
5fa0080
Merge branch 'master' of github.com:apache/druid into glueclassload
a2l007 May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions ...d-iceberg-extensions/src/main/java/org/apache/druid/iceberg/input/GlueIcebergCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,10 @@
import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.databind.ObjectMapper;
import org.apache.druid.guice.annotations.Json;
import org.apache.druid.java.util.common.RE;
import org.apache.druid.java.util.common.logger.Logger;
import org.apache.druid.utils.DynamicConfigProviderUtils;
import org.apache.iceberg.CatalogUtil;
import org.apache.iceberg.aws.glue.GlueCatalog;
import org.apache.iceberg.catalog.Catalog;

import javax.annotation.Nullable;
Expand Down Expand Up @@ -95,7 +96,21 @@ private Catalog setupGlueCatalog()
{
// We are not passing any hadoop config, third parameter is null
catalogProperties.put("type", TYPE_KEY);
catalog = CatalogUtil.buildIcebergCatalog(CATALOG_NAME, catalogProperties, null);

// AWS Glue catalog internally uses reflection to locate certain classes from the iceberg-aws dependency.
// These classes are not available in the current context class loader, and so we explicitly set the context class loader to the system classloader.
ClassLoader currCtxClassloader = Thread.currentThread().getContextClassLoader();
try {
Thread.currentThread().setContextClassLoader(getClass().getClassLoader());
catalog = new GlueCatalog();
catalog.initialize(CATALOG_NAME, catalogProperties);
}
catch (Exception e) {
throw new RE(e, "Failed to initialize Glue catalog");
}
finally {
Thread.currentThread().setContextClassLoader(currCtxClassloader);
}
return catalog;
}

Expand Down
Loading