Update PolicyEnforcer to only validate table based segment.#18018
Merged
cryptoe merged 1 commit intoapache:masterfrom May 20, 2025
Merged
Update PolicyEnforcer to only validate table based segment.#18018cryptoe merged 1 commit intoapache:masterfrom
cryptoe merged 1 commit intoapache:masterfrom
Conversation
github-actions
Bot
added
Area - Batch Ingestion
Area - MSQ
Contributor
Author
|
Was supposed to add this in PR #17960 - I overlooked it. |
cryptoe
approved these changes
May 20, 2025
| // Validation will always fail on lookups, external, and inline segments, because they will not have policies applied (except for NoopPolicyEnforcer). | ||
| // This is a temporary solution since we don't have a perfect way to identify segments that are backed by a regular table yet. | ||
| SegmentId segmentId = segment.getId(); | ||
| // SegmentId is null if the segment is not table based, or is already closed |
Contributor
There was a problem hiding this comment.
Just wanted to understand what does segment close mean.
Contributor
|
Please add docs if any are needed to call out this behavior. Something like row policies are not enforced on following datassources:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update PolicyEnforcer to only validate table based segment.
This PR has: