Skip to content

Web console: add Error column to the tasks view #18057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vogievetsky merged 1 commit into from
May 31, 2025
Merged

Web console: add Error column to the tasks view #18057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion web-console/src/views/tasks-view/__snapshots__/tasks-view.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,18 @@ exports[`TasksView matches snapshot 1`] = `
"Type",
"Datasource",
"Status",
"Error",
"Created time",
"Duration",
"Location",
]
}
onChange={[Function]}
tableColumnsHidden={[]}
tableColumnsHidden={
[
"Error",
]
}
/>
</Memo(ViewControlBar)>
<ReactTable
Expand Down Expand Up @@ -182,6 +187,15 @@ exports[`TasksView matches snapshot 1`] = `
"sortMethod": [Function],
"width": 110,
},
{
"Aggregated": [Function],
"Cell": [Function],
"Header": "Error",
"accessor": [Function],
"id": "error",
"show": false,
"width": 300,
},
{
"Aggregated": [Function],
"Cell": [Function],
Expand Down
11 changes: 11 additions & 0 deletions web-console/src/views/tasks-view/tasks-view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ const taskTableColumns: string[] = [
'Type',
'Datasource',
'Status',
'Error',
'Created time',
'Duration',
'Location',
Expand Down Expand Up @@ -167,6 +168,7 @@ ORDER BY

visibleColumns: new LocalStorageBackedVisibility(
LocalStorageKeys.TASK_TABLE_COLUMN_SELECTION,
['Error'],
),
};

Expand Down Expand Up @@ -476,6 +478,15 @@ ORDER BY
},
show: visibleColumns.shown('Status'),
},
{
Header: 'Error',
id: 'error',
accessor: row => row.error_msg || '',
width: 300,
Cell: this.renderTaskFilterableCell('error'),
Aggregated: () => '',
show: visibleColumns.shown('Error'),
},
{
Header: 'Created time',
accessor: 'created_time',
Expand Down