Skip to content

Update aws.sdk.version#18068

Merged
abhishekrb19 merged 2 commits intoapache:masterfrom
thalesac:patch-1
Jun 4, 2025
Merged

Update aws.sdk.version#18068
abhishekrb19 merged 2 commits intoapache:masterfrom
thalesac:patch-1

Conversation

@thalesac
Copy link
Copy Markdown
Contributor

@thalesac thalesac commented Jun 3, 2025

This PR updates the AWS Java SDK version used in Apache Druid to version 1.12.746. This patch upgrade is necessary to enable support for EKS Pod Identity credentials, as documented in the AWS EKS documentation.

Description

Bumped AWS SDK for Java to 1.12.746 to meet the minimum requirement for EKS Pod Identity.

No API changes or behavioral changes are introduced; this is a patch version bump only and remains backward compatible.

Release note

Adding support for AWS EKS Pod Identity credentials


Key changed/added classes in this PR
  • pom.xml update

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

In order to support EKS Pod Identity credentials, the minimum sdk version should be 1.12.746.
Its compatible with the current API.
https://docs.aws.amazon.com/eks/latest/userguide/pod-id-minimum-sdk.html
@gianm
Copy link
Copy Markdown
Contributor

gianm commented Jun 3, 2025

Thank you @thalesac for the contribution! To fix the error in Static Checks CI / static-checks (17) (pull_request), please update the versions in licenses.yaml:

Error: found 4 missing licenses. These licenses are reported, but missing in the registry
druid_module: kinesis-indexing-service, groupId: com.amazonaws, artifactId: aws-java-sdk-sts, version: 1.12.784, license: Apache License version 2.0
druid_module: kinesis-indexing-service, groupId: com.amazonaws, artifactId: jmespath-java, version: 1.12.784, license: Apache License version 2.0
druid_module: druid-aws-rds-extensions, groupId: com.amazonaws, artifactId: aws-java-sdk-rds, version: 1.12.784, license: Apache License version 2.0
druid_module: kinesis-indexing-service, groupId: com.amazonaws, artifactId: aws-java-sdk-kinesis, version: 1.12.784, license: Apache License version 2.0

This change updates the version of the AWS SDK for Java to ensure compatibility with the latest features and security improvements. Without this update, the application may miss out on critical updates and enhancements.

* Updated version from 1.12.638 to 1.12.784 to leverage new features and fixes.
* Maintained existing license information and module details for consistency.

Signed-off-by: Thales Ceolin <thales@ulevel.com>
@thalesac
Copy link
Copy Markdown
Contributor Author

thalesac commented Jun 3, 2025

Thanks for the prompt review @gianm :)
Just updated the licenses.yaml accordingly. Let's hope the tests pass.

@thalesac
Copy link
Copy Markdown
Contributor Author

thalesac commented Jun 3, 2025

@gianm any insights on why the tests failed? let me know if I can do anything on my end.

Correct if I'm wrong but the issues seems unrelated to the actual change.
Seems more like a temporary/permanent network issue.

5572.9 Connecting to downloads.apache.org (downloads.apache.org)|2a01:4f8:10a:39da::2|:443... failed: Network is unreachable.
5572.9 Connecting to downloads.apache.org (downloads.apache.org)|2a01:4f9:3a:2c57::2|:443... failed: Network is unreachable.

@abhishekrb19
Copy link
Copy Markdown
Contributor

abhishekrb19 commented Jun 3, 2025

I just restarted the failed jobs. Some of the IT failures like the ones you shared above look intermittent. Re the query IT failures, it should be fixed with #18067.

Copy link
Copy Markdown
Contributor

@abhishekrb19 abhishekrb19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks for the contribution @thalesac! CI looks good to me, the three failing ITs are being fixed in #18067.

@abhishekrb19 abhishekrb19 merged commit f03a961 into apache:master Jun 4, 2025
72 of 75 checks passed
@capistrant capistrant added this to the 34.0.0 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants