Docs: Add metrics and configs for embedded kill tasks#18124
Docs: Add metrics and configs for embedded kill tasks#18124kfaraz merged 3 commits intoapache:masterfrom
Conversation
abhishekrb19
left a comment
abhishekrb19
left a comment
There was a problem hiding this comment.
Lgtm, left two suggestions, thanks!
| - can keep up with a large number of unused segments in the cluster. | ||
| - take advantage of the segment metadata cache on the Overlord. | ||
|
|
||
| This feature can be used only if [segment metadata caching](../configuration/index.md#segment-metadata-cache-experimental) is enabled on the Overlord. |
There was a problem hiding this comment.
It would be better to move this prerequisite above, perhaps into a separate ::info section for visibility.
There was a problem hiding this comment.
Is it okay to put it into the same info section as a separate bullet?
| ##### Auto-kill unused segments (Experimental) | ||
|
|
||
| These configs pertain to the new embedded mode of running [kill tasks on the Overlord](../data-management/delete.md#auto-kill-data-on-the-overlord-experimental). | ||
|
|
There was a problem hiding this comment.
I think it would be good to explicitly call out that none of the coordinator-based auto-kill configs apply to this overlord-based auto-kill feature (even in the combined coordinator+OL mode). Bringing this up because I had that assumption initially when reviewing #18028. The reasons are already cross-linked in data-management/delete.md, so it should be clear for anyone curious.
|
Thanks for the review, @abhishekrb19 ! |
|
Thanks for documenting, Kashif! |
Docs changes for apache#18028 - Document metrics and configs for embedded kill tasks - Remove duplicate configs for Coordinator auto-kill from `data-management/delete.md` - Fix up references
3 participants
Docs changes for #18028
Changes
data-management/delete.mdThis PR has: